global: codebase upgrade #1937
Merged
global: codebase upgrade #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
code-upgrade
branch
4 times, most recently
from
3d5d757
to
52d85fd
Compare
zzacharo
force-pushed
the
code-upgrade
branch
4 times, most recently
from
811e594
to
3676aec
Compare
zzacharo
force-pushed
the
code-upgrade
branch
2 times, most recently
from
e6a6de9
to
c7bfbb2
Compare
* Moves cds-js relevant code in the main repo * cds-js can be archived once the upgrade is completed * fix remote download workflow. Use `payload.uri` only when downloading a remote video
* dockerfile: move to python 3.9 * oauth: upgrade to latest cern openid contrib
kpsherva
reviewed
Aug 2, 2024
cds/modules/records/search.py
Outdated
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| from __future__ import absolute_import, print_function | |||
|
|
|||
| from elasticsearch_dsl.query import Q | |||
| from opensearch_dsl.query import Q | |||
There was a problem hiding this comment.
Suggested change
| from opensearch_dsl.query import Q | |
| from invenio_search import dsl |
kpsherva
reviewed
Aug 2, 2024
cds/modules/records/search.py
Outdated
| @@ -59,14 +59,12 @@ def cern_filter(): | |||
| provides = get_user_provides() | |||
|
|
|||
| # Filter for public records | |||
| public = Q("missing", field="_access.read") | |||
| public = ~Q("exists", field="_access.read") | |||
There was a problem hiding this comment.
Suggested change
| public = ~Q("exists", field="_access.read") | |
| public = ~dsl.query.Q("exists", field="_access.read") |
There was a problem hiding this comment.
not sure how accurate this is, better to check in ILS
kpsherva
reviewed
Aug 2, 2024
cds/modules/records/utils.py
Outdated
| @@ -29,9 +29,10 @@ | |||
| import json | |||
|
|
|||
| import six | |||
| from elasticsearch.exceptions import NotFoundError | |||
| from opensearchpy.exceptions import NotFoundError | |||
There was a problem hiding this comment.
safer to import via invenio_search
kpsherva
reviewed
Aug 2, 2024
| }, | ||
| } | ||
| }) | ||
| // require.config({ |
kpsherva
reviewed
Aug 2, 2024
docker/app/Dockerfile
Outdated
| @@ -5,13 +5,13 @@ | |||
| # invenio-app-ils is free software; you can redistribute it and/or modify it | |||
| # under the terms of the MIT License; see LICENSE file for more details. | |||
|
|
|||
| FROM python:3.6 | |||
| FROM python:3.9 | |||
There was a problem hiding this comment.
/inveniosoftware/almalinux:1?
* fix doi test to ensure that doi cannot be changes once minted * fix keyword serialization check * replace opensearch_dsl occurences with invenio_search ones * delete redundant js files
zzacharo
force-pushed
the
code-upgrade
branch
16 times, most recently
from
7545dc2
to
5cbe877
Compare
kpsherva
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.