Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README.rst #1971

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Updated README.rst #1971

merged 2 commits into from
Oct 30, 2024

Conversation

zubeydecivelek
Copy link
Contributor

@zubeydecivelek zubeydecivelek commented Oct 30, 2024 •
edited
Loading

closes #1968

@zubeydecivelek zubeydecivelek linked an issue Oct 30, 2024 that may be closed by this pull request
update of README.rst #1968
Closed
zzacharo
zzacharo reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! A small minor comment.

Can I ask you to delete also the INSTALL.rst please? Also, for the PR to close automatically the linked issue you should prepend closes before the link to the issue.

README.rst Show resolved Hide resolved
@zzacharo zzacharo merged commit 100fccb into CERNDocumentServer:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzacharo zzacharo zzacharo approved these changes

@jrcastro2 jrcastro2 Awaiting requested review from jrcastro2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update of README.rst
2 participants
@zubeydecivelek @zzacharo