make DOI optional and add CLI command for DOI minting #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zubeydecivelek
commented
Nov 18, 2024
zubeydecivelek
commented
- Removed DOI minting code for video
- Added a CLI command to mint DOI
- Updated FAQ section to request a DOI
- Updated tests to reflect the changes
- Removed DOI minting code for video types - Added a CLI command to mint DOI - Updated FAQ section to request a DOI - Updated tests to reflect the changes
3 tasks
jrcastro2
reviewed
Nov 18, 2024
zzacharo
reviewed
Nov 19, 2024
| @@ -528,6 +526,67 @@ def test_record_video_links( | |||
| } | |||
|
|
|||
|
|
|||
| @mock.patch("invenio_pidstore.providers.datacite.DataCiteMDSClient") | |||
| def test_mint_doi_with_cli( | |||
There was a problem hiding this comment.
Really nice and clear test :)
zzacharo
reviewed
Nov 19, 2024
zubeydecivelek
force-pushed
the
make-doi-optional
branch
from
1c98157 to
912dbb1
Compare
zzacharo
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.