Skip to content

fix(identity): create the identity when missing #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kpsherva merged 1 commit into from
Oct 30, 2025
Merged

fix(identity): create the identity when missing #10

kpsherva merged 1 commit into from
Oct 30, 2025

Conversation

@ntarocco
Copy link
Contributor

@ntarocco ntarocco commented Oct 29, 2025

  • when the identity is missing, the sync will not create it without failing

@ntarocco ntarocco force-pushed the fix/missing-identity branch 2 times, most recently from b3e8b09 to b0f10b1 Compare October 29, 2025 12:47
@ntarocco
fix(identity): create the identity when missing
fe6515e 
- when the identity is missing, the sync will not create it
  without failing
@ntarocco ntarocco force-pushed the fix/missing-identity branch from b0f10b1 to fe6515e Compare October 29, 2025 12:52
kpsherva
kpsherva approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@kpsherva kpsherva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
minor: looks like we don't use black in this module

@ntarocco
Copy link
Contributor Author

ntarocco commented Oct 29, 2025

LGTM! minor: looks like we don't use black in this module

I used black to reformat the code, otherwise tests will fail. What do you mean?

@kpsherva
Copy link
Contributor

kpsherva commented Oct 30, 2025

LGTM! minor: looks like we don't use black in this module

I used black to reformat the code, otherwise tests will fail. What do you mean?

#10 (comment) I saw this long line and it gave me the impression that it wasn't formatted. all good then !

@kpsherva kpsherva merged commit 721dcde into CERNDocumentServer:main Oct 30, 2025
2 checks passed
@ntarocco ntarocco deleted the fix/missing-identity branch October 30, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpsherva kpsherva kpsherva approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ntarocco @kpsherva