validation: Add LYD_VALIDATE_NOEXTDEPS to bypass leafref/when/must #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In libyang v1, there was an LYD_OPT_NOEXTDEPS flag. This was removed, and this patch re-adds a flag with similar functionality.
|
We have discussed this flag and as I have said before, we removed it intentionally and we do not want to support it because it is not reliable and, what is worse, leads to bad design of applications. |
|
understood, just one of those policies to always submit upstream :) We'll maintain this patch separately in SONiC until the code that relies on this can be rearchitected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libyang v1, there was an LYD_OPT_NOEXTDEPS flag. This was removed, and this patch re-adds a flag with similar functionality.
The gNMI/RESTCONF portion of the SONiC port is currently relying on this patch:
sonic-net/sonic-mgmt-common#157
If this isn't accepted upstream, we'll need to maintain this patch separately.
Fixes #2355