ly_path_parse OPTIMIZE fail faster on invalid path #2368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfanHaslanded
force-pushed
the
irfan/opt-union
branch
from
278e51f to
9ef7aa9
Compare
michalvasko
reviewed
Mar 18, 2025
irfanHaslanded
force-pushed
the
irfan/opt-union
branch
3 times, most recently
from
84c019f to
9385d06
Compare
michalvasko
reviewed
Mar 18, 2025
irfanHaslanded
force-pushed
the
irfan/opt-union
branch
from
9385d06 to
1f73f5c
Compare
`ly_path_parse()` is called from various functions like `lyplg_type_store_node_instanceid()` and `lyplg_type_lypath_new()` with the `LY_PATH_BEGIN_ABSOLUTE` flag set. This means that the path is expected to start with a '/' character. If it doesn't, this could mean that the value is not a valid path. This can happen while finding a union type, where it is not optimal to call `lyxp_expr_parse()`, which is much heavier to compute.
irfanHaslanded
force-pushed
the
irfan/opt-union
branch
from
1f73f5c to
22d2a1b
Compare
michalvasko
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ly_path_parse()is called from various functions likelyplg_type_store_node_instanceid()andlyplg_type_lypath_new()with theLY_PATH_BEGIN_ABSOLUTEflag set.This means that the path is expected to start with a '/' character. If it doesn't, this could mean that the value is not a valid path.
This can happen while finding a union type, where it is not optimal to call
lyxp_expr_parse(), which is much heavier to compute.