Add google-build-using-namespace check

CExA-project · Oct 13, 2024 · d5774f4 · d5774f4
1 parent d309c0e
commit d5774f4
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 7 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -31,7 +31,6 @@ cppcoreguidelines-*,
 -cppcoreguidelines-rvalue-reference-param-not-moved,
 -cppcoreguidelines-special-member-functions,
 google-*,
--google-build-using-namespace,
 -google-explicit-constructor,
 -google-readability-casting,
 -google-readability-todo,

diff --git a/include/ddc/detail/tagged_vector.hpp b/include/ddc/detail/tagged_vector.hpp
@@ -332,15 +332,13 @@ class TaggedVector : public TaggedVectorConversionOperators<TaggedVector<Element
     template <class QueryTag>
     KOKKOS_FUNCTION constexpr ElementType& get() noexcept
     {
-        using namespace detail;
         static_assert(in_tags_v<QueryTag, tags_seq>, "requested Tag absent from TaggedVector");
         return m_values[type_seq_rank_v<QueryTag, tags_seq>];
     }
 
     template <class QueryTag>
     KOKKOS_FUNCTION constexpr ElementType const& get() const noexcept
     {
-        using namespace detail;
         static_assert(in_tags_v<QueryTag, tags_seq>, "requested Tag absent from TaggedVector");
         return m_values[type_seq_rank_v<QueryTag, tags_seq>];
     }

diff --git a/include/ddc/discrete_element.hpp b/include/ddc/discrete_element.hpp
@@ -210,15 +210,13 @@ class DiscreteElement
     template <class QueryTag>
     KOKKOS_FUNCTION constexpr value_type& uid() noexcept
     {
-        using namespace detail;
         static_assert(in_tags_v<QueryTag, tags_seq>, "requested Tag absent from DiscreteElement");
         return m_values[type_seq_rank_v<QueryTag, tags_seq>];
     }
 
     template <class QueryTag>
     KOKKOS_FUNCTION constexpr value_type const& uid() const noexcept
     {
-        using namespace detail;
         static_assert(in_tags_v<QueryTag, tags_seq>, "requested Tag absent from DiscreteElement");
         return m_values[type_seq_rank_v<QueryTag, tags_seq>];
     }

diff --git a/include/ddc/discrete_vector.hpp b/include/ddc/discrete_vector.hpp
@@ -319,15 +319,13 @@ class DiscreteVector : public detail::DiscreteVectorConversionOperators<Discrete
     template <class QueryTag>
     KOKKOS_FUNCTION constexpr DiscreteVectorElement& get() noexcept
     {
-        using namespace detail;
         static_assert(in_tags_v<QueryTag, tags_seq>, "requested Tag absent from DiscreteVector");
         return m_values[type_seq_rank_v<QueryTag, tags_seq>];
     }
 
     template <class QueryTag>
     KOKKOS_FUNCTION constexpr DiscreteVectorElement const& get() const noexcept
     {
-        using namespace detail;
         static_assert(in_tags_v<QueryTag, tags_seq>, "requested Tag absent from DiscreteVector");
         return m_values[type_seq_rank_v<QueryTag, tags_seq>];
     }