-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependencies on installed DDC #665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tpadioleau
force-pushed
the
307-make-ddc-installable
branch
3 times, most recently
from
October 16, 2024 16:16
0fe2375
to
d64e70b
Compare
tpadioleau
commented
Oct 16, 2024
tpadioleau
force-pushed
the
307-make-ddc-installable
branch
5 times, most recently
from
October 16, 2024 20:54
ba0d26e
to
565525f
Compare
tpadioleau
force-pushed
the
307-make-ddc-installable
branch
2 times, most recently
from
October 23, 2024 14:45
87254c5
to
561f71c
Compare
tpadioleau
force-pushed
the
307-make-ddc-installable
branch
from
October 23, 2024 15:16
561f71c
to
41c27ad
Compare
If you added ddc/.github/workflows/tests.yml Line 19 in 579427b
|
Indeed good catch |
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be working but could be further improved in future PR.
The headers related to fft, splines and the PDI wrapper of DDC are being installed whatever the values of the cmake options. I think it could improved with some reorganization.
Cmake targets about the fft and splines are missing.
We should look at cmake components. As long as the user can adapt it looks ok
but as soon as a user requires an option this looks bad