Remove unnecessary compile definitions#672
Conversation
f14218d to
84b0ef9
Compare
1063899 to
7e9b0c9
Compare
There was a problem hiding this comment.
Internally to DDC, one has to include this file when the preprocessor macros are used to avoid any surprise
c20122c to
ddef80a
Compare
3c51b3d to
52d4b74
Compare
52d4b74 to
9343a8a
Compare
yasahi-hpc
left a comment
There was a problem hiding this comment.
Looks good. Regarding examples, do you need PDI enabled versions for all examples? Since it is an advanced usage, I think one example is sufficient. Making other examples as simple as possible without PDIs would help beginners.
thanks!
Need, no. It was introduced to be sure we compile the PDI related classes. I don't know yet how to write PDI tests. |
Removed:
target_compile_definitions(DDC INTERFACE "DDC_BUILD_KERNELS_FFT")target_compile_definitions(DDC INTERFACE "DDC_BUILD_KERNELS_SPLINES")target_compile_definitions(PDI_Wrapper INTERFACE "DDC_BUILD_PDI_WRAPPER")target_compile_definitions(DDC INTERFACE DDC_BUILD_DOUBLE_PRECISION)is replaced by aconfig.hpp.infile.DDC public headers
<ddc/ddc.hpp>available using cmake targetDDC::DDC<ddc/kernels/fft.hpp>available using cmake targetDDC::DDCif cmake optionDDC_BUILD_KERNELS_FFT=ON<ddc/kernels/splines.hpp>available using cmake targetDDC::DDCif cmake optionDDC_BUILD_KERNELS_SPLINES=ON<ddc/pdi.hpp>available using cmake targetDDC::PDI_Wrapperif cmake optionDDC_BUILD_PDI_WRAPPER=ON