Polygon mesh snapping improvements #9266
Open
+124
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The point is that we can then either pass a tolerance map, or a constant fixed value.
This is because if meshes are different, the target edge is fixed. But if we are self-snapping, the edge might move because one of its extremity might itself have been a vertex involved in vertex-edge snapping.
otherwise the tolerance (esp. the automatic one using 0.9 * min_inc_edge_l) can grow too large and allow snapping to a neighbor-of-neighbor edge, which obviously we need to avoid.
|
|
||
| vertices_to_snap.emplace_back(h, tolerance); | ||
|
|
||
| // take the min tolerance for all vertices with at the same position |
Contributor
There was a problem hiding this comment.
with -> which are? or remove the word at?
MaelRL
commented
Jan 12, 2026
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Snapping/snap.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
A few improvements for the experimental polygon mesh snapping functions of PMP.
Release Management
PMP