Mesh_2: fix degenerate cases #9290
Open
+1,597
−266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new bisect_failures template function to help identify minimal failing test cases from complex input data. The utility uses a bisection-like approach to iteratively simplify data and locate the smallest subset that causes failures. Features: - Handles multiple failure types: CGAL exceptions, std::exceptions, exit codes - Automatic ratio adjustment (starts at 0.5, halves when no fault found) - Saves intermediate states for debugging (current, bad, error, final_bad) - Comprehensive test suite with 14 tests covering all combinations: * Edge cases (empty data, no failures) * Single element failures (each failure type independently) * Pair combinations (all 2-element permutations) * Triple combinations (all 3 failure types together) * Large datasets (up to 200 elements) The test suite demonstrates complete combinatorial coverage of three independent failure conditions and validates the algorithm's ability to isolate minimal failing cases. All tests pass in both Debug and Release configurations.
Co-authored-by: Andreas Fabri <[email protected]>
…rineau' into pr/afabri/8429
sloriot
reviewed
Jan 21, 2026
Member
Author
|
Even if this PR is a bug-fix, I would prefer it to be in CGAL-6.2 only, because there is a breaking change on the requirements of the traits class: a48e7ee#diff-13fc09a664b393d1a17f16b50657be2bc99df52a992c50a2880ad88525d823bc |
afabri
reviewed
Jan 21, 2026
afabri
reviewed
Jan 21, 2026
[skip ci]
afabri
reviewed
Jan 21, 2026
lrineau
force-pushed
the
Mesh_2-fix_degenerate_cases-GF
branch
from
8eaa596 to
a8e9bbe
Compare
Member
|
Bug reported in the CI, also in the testsuite. |
`Base_with_time_stamp` was renamed `Triangulation_simplex_base_with_time_stamp` without compatibility (and I have the former header on my machine)
That will probably fix the testsuite results of Surface_mesher.
sloriot
reviewed
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR fixes the error reported in issue #781. The main two changes are:
Refine_edges.h: allow the refinement point of a constrained edge to be an existing close encroaching vertex,Refine_faces.h: skip tiny bad faces when their bbox are smaller than a few ulp.Release Management