Skip to content

Enhance Error Handling #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enhance Error Handling #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26d5644
enhance error handling
georgezzeng Jan 30, 2025
a12f59c
Merge branch 'main' into nextjs
georgezzeng Jan 30, 2025
b5dbceb
enhance error handling
georgezzeng Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 46 additions & 23 deletions src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ function MarkdownContent() {
const markdownUrl = searchParams.get("url");

const [article, setArticle] = useState<BackendArticle | null>(null);

const [error, setError] = useState<string | undefined>(undefined);
const [isLoading, setIsLoading] = useState<boolean>(true);

useEffect(() => {
(async () => {
Expand All @@ -38,35 +38,50 @@ function MarkdownContent() {
return;
}

let response;
try {
response = await fetch(markdownUrl);
const response = await fetch(markdownUrl);
if (!response.ok) {
setError(`Failed to fetch markdown: ${response.statusText}`);
return
setIsLoading(false);
return;
}
} catch (e) {
setError(`Failed to fetch markdown: ${e}`);
return
}

const markdown = await response.text()
const markdown = await response.text();

let parsedData;
try {
parsedData = grayMatter(markdown);
} catch {
setError("Error parsing markdown file. Ensure it has valid frontmatter");
setIsLoading(false);
return;
}

const {data, content} = grayMatter(markdown);
const { data, content } = parsedData;
const pathParts = markdownUrl.split("/");
const filename = pathParts[pathParts.length - 1] || "";

const path = markdownUrl.split("/").slice(-1)[0];
const date = new Date(path.split("-").slice(0, 3).join("-"));
if (!filename) {
setError("Invalid markdown file path");
setIsLoading(false);
return;
}

const article = {
slug: [],
date: date,
path: markdownUrl.split("/").slice(-1)[0],
content,
...(data as Omit<ArticleType, "content" | "date">)
const dateParts = filename.split("-").slice(0, 3);
const date = dateParts.length === 3 ? new Date(dateParts.join("-")) : new Date();

setArticle({
slug: [],
date: date,
path: filename,
content,
...(data as Omit<ArticleType, "content" | "date">)
} as BackendArticle);
} catch {
setError("Article fetch failed");
} finally {
setIsLoading(false);
}

setArticle(article as BackendArticle)
setError(undefined)
})();
}, [markdownUrl, searchParams]);

Expand All @@ -79,12 +94,20 @@ function MarkdownContent() {
)
}

if (isLoading) {
return (
<Container>
<h1>Loading...</h1>
</Container>
);
}

if (!article) {
return (
<Container>
<h1>Loading</h1>
<h1>No article found</h1>
</Container>
)
);
}

return (
Expand Down