Add separate page for converting docker images to apptainer images#836
Merged
Add separate page for converting docker images to apptainer images#836
Conversation
Contributor
Author
aowen-uwmad
approved these changes
Nov 14, 2024
Contributor
aowen-uwmad
left a comment
aowen-uwmad
left a comment
There was a problem hiding this comment.
Some suggestions, good to merge when you are ready.
Co-authored-by: Andrew Owen <60940495+aowen-uwmad@users.noreply.github.com>
Co-authored-by: Andrew Owen <60940495+aowen-uwmad@users.noreply.github.com>
ChristinaLK
approved these changes
Nov 15, 2024
Contributor
ChristinaLK
left a comment
ChristinaLK
left a comment
There was a problem hiding this comment.
lgtm. 1-2 things to check.
| ``` | ||
|
|
||
| > If you just want to convert an existing Docker container into an Apptainer container, you do not need to use a definition file. | ||
| > Instead, you can directly run the `apptainer build` command using the Docker address, as described [below](#converting-a-docker-image-to-an-apptainer-container-image). |
Contributor
There was a problem hiding this comment.
are these instructions still below? or on the new page?
Contributor
Author
There was a problem hiding this comment.
I left the instructions on this page
Co-authored-by: Christina K. <christinakconnect@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added a section for building on local apptainer images