-
Notifications
You must be signed in to change notification settings - Fork 33
Revised login guides, new "basic shell commands" guide, custom CSS #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@CannonLock Can you specifically review the CSS? I hacked this together, but I want to ensure that this is okay to do, or if there's another way to implement this kind of formatting. |
ChristinaLK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! Things I'll want to discuss at some point:
- items that fall under "style guide" - agreeing on how we capitalize headers, and confirming that we want to remove outline numbers/letters in our headers(I'm in favor esp now that we have clickable headers, just want to document).
- sort of related -- going through a few guides together and how we would restructure them to match the format you've created here.
- I see the summary possibly getting out of date because we forget to update it as we update the page. 😅
- What are your thoughts on adding some more formatting to our header styles to better distinguish levels 1 - 4? We did this on the OSG docs (a little) and it looks like this: https://portal.osg-htc.org/documentation/htc_workloads/using_software/containers-singularity/
I LOVE the way it looks to have the 2FA video in its own "tip" box. If we make a bunch more videos, that's a good model for integrating them. Ditto having the table of ssh tools - am realizing we could use those a LOT MORE in our docs and that's a great use case.
I added the suggestions about Option 1 vs Option 2 -- not sure if that's strictly necessary, but I like to clarify when two headers are sequential / additive vs disjoint, if that makes sense? But I also don't need to die on that hill, partially because I don't like the way it looks - I prefer the simplicity of just the header name. :)
aowen-uwmad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go after addressing comments.
CannonLock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Major changes
{:.tip-header}and{:.tip}to block quotes. See an example here.Less major (but still not minor) changes