Template for sealevelponds CICE changes

[dabail10]

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

• Short (1 sentence) summary of your PR:
  Draft PR for CICE changes needed to call sealevelponds in icepack.
• Developer(s):
  D. Bailey (dabail10)
• Suggest PR reviewers from list in the column to the right.
• Please copy the PR test results link or provide a summary of testing completed below.
  These test results include a second PR that will come shortly after this one.
  https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#bf2aa3f4abce18d657724bb72dae86cf715fe963
  https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#f000063a5b35adcdaed4c569179a200456576d94
• How much do the PR code changes differ from the unmodified code?
  • bit for bit
  • different at roundoff level
  • more substantial
• Does this PR create or have dependencies on Icepack or any other models?
  • Yes
  • No
• Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
  • Yes
  • No
• Does this PR add any new test cases?
  • Yes
  • No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No
• Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

This is needed for the new sea level ponds scheme in Icepack.

[apcraig]

Please add a restart test in the base suite for the new ponds option.

[apcraig]

apnd_sl has not been added to the source code as a valid namelist option. The CICE testing is aborting on derecho (using the Icepack sealevelponds code).

[dabail10]

Apologies. I have added it now.

[apcraig]

Testing looks OK, but the pondsealevel test fails on all compilers on derecho. One test is

FAIL derecho_intel_restart_gx3_8x2_pondsealvl run

The model aborts at the start, probably while writing the initial history file. The error message is

 (abort_ice)ABORTED: 
 (abort_ice) called from /glade/work/tcraig/cice-consortium/cice.sealevelponds/cicecore/cicedyn/infrastructure/io/io_netcdf/ice_history_write.F90
 (abort_ice) line number          982
 (abort_ice) error = (ice_check_nc) NetCDF: Numeric conversion not representable, (ice_write_hist) ERROR: writing variable hpond
MPICH ERROR [Rank 0] [job id 9ed14ad5-d710-4c94-985f-7adf92f881e8] [Fri May  2 21:28:33 2025] [dec2440] - Abort(128) (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 128) - process 0

[dabail10]

Testing looks OK, but the pondsealevel test fails on all compilers on derecho. One test is

FAIL derecho_intel_restart_gx3_8x2_pondsealvl run

The model aborts at the start, probably while writing the initial history file. The error message is

 (abort_ice)ABORTED: 
 (abort_ice) called from /glade/work/tcraig/cice-consortium/cice.sealevelponds/cicecore/cicedyn/infrastructure/io/io_netcdf/ice_history_write.F90
 (abort_ice) line number          982
 (abort_ice) error = (ice_check_nc) NetCDF: Numeric conversion not representable, (ice_write_hist) ERROR: writing variable hpond
MPICH ERROR [Rank 0] [job id 9ed14ad5-d710-4c94-985f-7adf92f881e8] [Fri May  2 21:28:33 2025] [dec2440] - Abort(128) (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 128) - process 0

Interesting. I will investigate this further on Monday.

[dabail10]

/glade/work/tcraig/cice-consortium/cice.sealevelponds/cicecore/cicedyn/

Apologies. I forgot the call to write_restart_pond_sealvl in CICE_RunMod.F90 for the standalone driver.

[dabail10]

vicd ..

Testing looks OK, but the pondsealevel test fails on all compilers on derecho. One test is
FAIL derecho_intel_restart_gx3_8x2_pondsealvl run
The model aborts at the start, probably while writing the initial history file. The error message is

 (abort_ice)ABORTED: 
 (abort_ice) called from /glade/work/tcraig/cice-consortium/cice.sealevelponds/cicecore/cicedyn/infrastructure/io/io_netcdf/ice_history_write.F90
 (abort_ice) line number          982
 (abort_ice) error = (ice_check_nc) NetCDF: Numeric conversion not representable, (ice_write_hist) ERROR: writing variable hpond
MPICH ERROR [Rank 0] [job id 9ed14ad5-d710-4c94-985f-7adf92f881e8] [Fri May  2 21:28:33 2025] [dec2440] - Abort(128) (rank 0 in comm 0): application called MPI_Abort(MPI_COMM_WORLD, 128) - process 0

Interesting. I will investigate this further on Monday.

I have submitted a fix for this.

[apcraig]

Thanks @dabail10. When you're ready, push the update and I'll test again too.

[dabail10]

Thanks @dabail10. When you're ready, push the update and I'll test again too.

It should be there already.

[apcraig]

The change is not in the github repo on your CICE sealevelponds2 branch. This should be a change in CICE_RunMod.F90 in the standalone driver in CICE, right.

[dabail10]

Sorry, I forgot I had created the sealevelponds2 branch

[dabail10]

@apcraig @eclare108213 I think I have updated everything here.

[eclare108213]

Please test and post results. Otherwise this looks good. I assume github actions is failing because it doesn't have the updated version of icepack. Thanks!

[apcraig]

I ran a full test suite on derecho with intel, gnu, and cray and everything looks good.
https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#ad0952b3748bff59a204b03536ce7a3646be0071
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#02733f9e8f3307e4be5bb918bdec8ece8534ac3a

[dabail10]

Awesome. Thanks Tony.

[apcraig]

I just noticed that the documentation has not been updated at all. There are several new namelists, at the very least. Maybe there should be some other updates in the documentation as well.

[eclare108213]

It looks like there might be some older code slipping in with this PR.
Also, the new namelist parameters apnd_sl and tscale_pnd_drain need to be added to the documentation, along with some mention of the sealvl pond scheme

[eclare108213]

I'll work on the documentation.

[eclare108213]

The fields in lines 538-546 should have the form
field(:,:,1:ncat_hist,iblk)
I don't think this will change the output for standard 5-category runs.

[apcraig]

I am merging this now. This will break CICE, but there will be a followup PR immediately following that finishes this work and updates Icepack and CICE again.
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#bf2aa3f4abce18d657724bb72dae86cf715fe963
https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#f000063a5b35adcdaed4c569179a200456576d94

[apcraig]

Approved based on testing with another PR to follow. I acknowledge merging this now will break CICE.