Skip to content

macOS 10.14+ universal x86_64/arm64 build with Max SDK 8.2 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

macOS 10.14+ universal x86_64/arm64 build with Max SDK 8.2 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
[submodule "ThirdParty/Max7-sdk"]
path = ThirdParty/Max7-sdk
url = https://github.com/Cycling74/max-sdk.git
[submodule "ThirdParty/Max8-sdk"]
path = ThirdParty/Max8-sdk
url = https://github.com/Cycling74/max-sdk
8 changes: 4 additions & 4 deletions MaxCommon/hoa.map_gui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,9 @@ void hoamap_source_dialog(t_hoa_map *x, Source* src)
{
if(src)
{
char *text = NULL;
const char *text = NULL;
char desc[100];
sprintf(desc, "Source %ld description :", src->getIndex());
snprintf(desc, sizeof(desc), "Source %ld description :", src->getIndex());
jdialog_showtext(desc, (char*)src->getDescription().c_str(), 0, &text);

if(text)
Expand All @@ -575,9 +575,9 @@ void hoamap_group_dialog(t_hoa_map *x, Source::Group* grp)
{
if(grp)
{
char *text = NULL;
const char *text = NULL;
char desc[100];
sprintf(desc, "Group %ld description :", grp->getIndex());
snprintf(desc, sizeof(desc), "Group %ld description :", grp->getIndex());
jdialog_showtext(desc, (char*)grp->getDescription().c_str(), 0, &text);

if(text)
Expand Down
4 changes: 2 additions & 2 deletions MaxCommon/hoa.process_tilde.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,7 +1829,7 @@ short hoa_processor_patcher_descend(t_patcher *p, t_intmethod fn, void *arg, t_h
return 0;

// CHANGED - DO NOT PASS x AS ARG
if ((*fn)(p, arg))
if ((*fn)(p /*, arg*/))
return (1);

for (b = jpatcher_get_firstobject(p); b; b = jbox_get_nextobject(b))
Expand Down Expand Up @@ -2103,4 +2103,4 @@ void *hoa_processor_client_get_patch_on (t_hoa_processor *x, long index)
return (void *) (long) x->patch_space_ptrs[index - 1]->patch_on;

return 0;
}
}
8 changes: 4 additions & 4 deletions MaxHoaLibrary.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
HOALIBRARY_VERSION = beta 2.2
PRODUCT_NAME = $(TARGET_NAME)
PRODUCT_VERSION = HoaLibrary $(HOALIBRARY_VERSION)
ARCHS = i386 x86_64
ARCHS = x86_64 arm64


// Paths
C74SUPPORT = $(SRCROOT)/ThirdParty/Max7-sdk/source/c74support
C74SUPPORT = $(SRCROOT)/ThirdParty/Max8-sdk/source/max-sdk-base/c74support
HEADER_SEARCH_PATHS = "$(C74SUPPORT)/max-includes" "$(C74SUPPORT)/msp-includes" "$(C74SUPPORT)/jit-includes"
FRAMEWORK_SEARCH_PATHS = "$(C74SUPPORT)/max-includes" "$(C74SUPPORT)/msp-includes" "$(C74SUPPORT)/jit-includes"
MAXPACKAGE = $(SRCROOT)/Package/HoaLibrary
Expand All @@ -26,7 +26,7 @@ INFOPLIST_FILE = $(SRCROOT)/Info.plist


// Architecture and Deployment
ARCHS = i386 x86_64
// REMOVED: duplicate ARCHS = i386 x86_64

// The following section sets the Mac SDK version to be used.
// For most projects this has little to no impact because there are no direct dependencies on OS function calls.
Expand All @@ -45,7 +45,7 @@ ARCHS = i386 x86_64
// Xcode 4.3+
// SDKROOT = macosx10.6

MACOSX_DEPLOYMENT_TARGET = 10.7
MACOSX_DEPLOYMENT_TARGET = 10.14


// Compiler Version -- leave them all commented out to get the default version provided by Xcode
Expand Down
8 changes: 4 additions & 4 deletions MaxHoaLibraryPacked.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
HOALIBRARY_VERSION = beta 2.2
PRODUCT_NAME = $(TARGET_NAME)
PRODUCT_VERSION = HoaLibrary $(HOALIBRARY_VERSION)
ARCHS = i386 x86_64
ARCHS = x86_64 arm64


// Paths
C74SUPPORT = $(SRCROOT)/ThirdParty/Max7-sdk/source/c74support
C74SUPPORT = $(SRCROOT)/ThirdParty/Max8-sdk/source/max-sdk-base/c74support
HEADER_SEARCH_PATHS = "$(C74SUPPORT)/max-includes" "$(C74SUPPORT)/msp-includes" "$(C74SUPPORT)/jit-includes"
FRAMEWORK_SEARCH_PATHS = "$(C74SUPPORT)/max-includes" "$(C74SUPPORT)/msp-includes" "$(C74SUPPORT)/jit-includes"
MAXPACKAGE = $(SRCROOT)/Package/HoaLibrary
Expand All @@ -26,7 +26,7 @@ INFOPLIST_FILE = $(SRCROOT)/Info.plist


// Architecture and Deployment
ARCHS = i386 x86_64
// REMOVED: duplicate ARCHS = i386 x86_64

// The following section sets the Mac SDK version to be used.
// For most projects this has little to no impact because there are no direct dependencies on OS function calls.
Expand All @@ -45,7 +45,7 @@ ARCHS = i386 x86_64
// Xcode 4.3+
// SDKROOT = macosx10.6

MACOSX_DEPLOYMENT_TARGET = 10.7
MACOSX_DEPLOYMENT_TARGET = 10.14


// Compiler Version -- leave them all commented out to get the default version provided by Xcode
Expand Down
1 change: 1 addition & 0 deletions ThirdParty/Max8-sdk
Open in desktop
Submodule Max8-sdk added at d6d5e5
Loading