-
Notifications
You must be signed in to change notification settings - Fork 142
Feature/tutorial review impact calculation #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This is not 100% correct, I'd say. 🧐
Rather an Exposures contains a |
Thanks for catching that @emanuel-schmid! I'll edit accordingly. |
@sarah-hlsn Not to worry. The test fails because since the v6.1 release, CLIMADA does not support Python 3.10 anymore. But the pipeline still tries to build an environment based on 3.10, so it's expected to fail. The error occurs now because |
Great, thanks for checking @peanutfun ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sarah, the PR looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought this review was submitted already a long time ago.
Most important is the comment on the intensities/impact values in the plot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "assingning" typo
- Probably unrelated to the tutorial, but I wonder why are the hazard intensities/impacts so different for the "User defined point exposure and Tropical Cyclone hazard". The intensities look wrong, actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I'm really curious/concerned with the intensities being between 0 and 1 in the point exposure example. This does not look to be related to your changes, but something is wrong somewhere. If you can briefly investigate, that would be wonderful.
This PR updates the Impact Calculation tutorial
Changes proposed in this PR:
Note: I had to rerun a lot of parts of this notebook due to code changes througout.
PR Author Checklist
develop
)PR Reviewer Checklist