Skip to content

Fix compilation on VS2017 #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2025
Merged

Fix compilation on VS2017 #1143

merged 2 commits into from
Apr 13, 2025

Conversation

huangqinjin
Copy link
Contributor

@huangqinjin huangqinjin commented Mar 24, 2025

The compiler complains about C2131: expression did not evaluate to a constant.

https://godbolt.org/z/a198P3bdM

huangqinjin and others added 2 commits March 24, 2025 12:00
The compiler complains about C2131: expression did not evaluate to a constant.
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4ee3af) to head (22a7256).
Report is 85 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1143     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           17        17             
  Lines         4546      5038    +492     
  Branches         0      1036   +1036     
===========================================
+ Hits          4546      5038    +492     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phlptp phlptp merged commit bc621a9 into CLIUtils:main Apr 13, 2025
58 of 59 checks passed
@huangqinjin huangqinjin deleted the fix-vs2017 branch April 13, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants