Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells and wafers are pairs of integers instead of single integer in new geometry #64

Open
clelange opened this issue Sep 11, 2018 · 3 comments
Labels
ntuple format Changes/issues related to the ntuple format

Comments

@clelange
Copy link
Contributor

Sunanda suggested to define wafer/cell as a pair in the ntupliser, for the old geometry the second integer will be 0. This will change the ntuple format.

@clelange clelange added the ntuple format Changes/issues related to the ntuple format label Sep 11, 2018
@rovere
Copy link
Contributor

rovere commented Sep 11, 2018

I'm not sure I follow. If the wafer/cell is returned as a pair in CMSSW, we can still decouple them and leave the format unchanged, no?

@clelange
Copy link
Contributor Author

Sorry, I wasn't clear: each cell is returned as a pair (either x-y coordinates or u-v), see https://github.com/cms-sw/cmssw/blob/master/DataFormats/ForwardDetId/interface/HGCSiliconDetId.h#L62, and so is each wafer for the new geometries.

BTW, we'd also have to choose u-v or x-y, but they can be converted easily:

int waferX() const { return (-2*waferU()+waferV()); }
int waferY() const { return (2*waferV()); }

@rovere
Copy link
Contributor

rovere commented Sep 11, 2018

Ah ok, this makes sense. I vote to store X,Y in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ntuple format Changes/issues related to the ntuple format
Projects
None yet
Development

No branches or pull requests

2 participants