Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to cart page, and introduced functionality to add items … #74

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ananyabhat
Copy link
Collaborator

…to cart and place an order and connected it to backend. Works towards #1

…to cart and place an order and connected it to backend.
Copy link
Collaborator

@ooj2899 ooj2899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good

@ananyabhat ananyabhat merged commit e5991c1 into master Mar 2, 2022
@mallocupiedRam
Copy link
Collaborator

Looks good! Perhaps in frontend/src/components/Customer/Cart.tsx in the subtotal function, you could use "partialSum" and "elem" for names instead of "sum" and "i" (especially since "i" is easily confused as an index)

@ananyabhat ananyabhat deleted the ananyabhat_placeorder branch March 19, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants