Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added success notification for adding to cart, added id selectors to … #78

Merged
merged 8 commits into from
Mar 25, 2022

Conversation

ananyabhat
Copy link
Collaborator

…elements in cart and menu, and began work on e2e test for customer. Works towards #1 and #77

…elements in cart and menu, and began work on e2e test for customer
@santoniriccardo
Copy link
Contributor

Seems like there are conflicting files. If these can be resolved I will accept.

@ananyabhat
Copy link
Collaborator Author

Seems like there are conflicting files. If these can be resolved I will accept.

Resolved! Tests are still failing, but that is because i haven't finished writing E2E test; will finish that up soon, feel free to accept PR now or wait till E2E test is finished and committed.

Copy link
Collaborator

@ooj2899 ooj2899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some errors that are not passing the checks I would say correct them then merge

@ananyabhat ananyabhat merged commit 535e593 into master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants