dead_band update #93
Merged
dead_band update #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change dead_band so that it can either be a single number or it can be a column of values per group
bpbond
requested changes
May 29, 2025
There was a problem hiding this comment.
Looks good @wilsonsj100 !
One suggestion: it would be useful to add a mention of this capability to the introductory vignette, for example, perhaps a brief comment ("# Here we use a constant dead band value, but this can also vary by group; see the documentation") here:
fluxfinder/vignettes/intro-to-fluxfinder.Rmd
Line 188 in 37aa694
bpbond
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change dead_band in ffi_compute_fluxes() so that users can enter either a single value (numeric) or a column of per group values