Simplify the create_regridder function #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
helenmacdonald
left a comment
helenmacdonald
left a comment
There was a problem hiding this comment.
Thanks @manishvenu - looks good to me but is there a place where we can put this warning back in:
Using existing weights file at {outfile} to save computing time. Delete weights file to regenerate weights
?
Collaborator
Author
|
Hey Helen, I added the warning back and added an arg to make sure the unmapped points become NaN, xesmf (or maybe ESMF) has this behavior of putting zeros if it's unmapped, which is just a mistake waiting to happen! |
helenmacdonald
approved these changes
Oct 6, 2025
Collaborator
helenmacdonald
left a comment
helenmacdonald
left a comment
There was a problem hiding this comment.
Thanks - looks good to me
Collaborator
Author
|
Awesome! Will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
create_regridderfunction default looks for the reuse_weights file if it exists using an if statement, instead we can follow this: pangeo-data/xESMF#234 (comment), which uses os.path.isfile instead.Fixes CROCODILE-CESM#58