Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various TDA19988 fixes #1821

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Various TDA19988 fixes #1821

merged 4 commits into from
Sep 5, 2023

Commits on Aug 29, 2023

  1. tda19988: Implement a non-stub mode_valid to filter unsupported resol… 

    …utions
    @jrtc27
    jrtc27 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a2bbba0 View commit details
    Browse the repository at this point in the history

  2. tda19988: Properly implement mode_set/bridge_enable/bridge_disable flow 

    Otherwise, when SDDM tries to put the display to sleep, we don't disable
the output and end up outputting a garbled picture, where the amount of
garbling increases with system activity.

Co-authored-by: Ruslan Bukin <[email protected]>
    @jrtc27 @bukinr
    jrtc27 and bukinr committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e227dac View commit details
    Browse the repository at this point in the history

  3. tda19988: Fix divisor calculation 

    The existing calculation was linear with a fixup to make it non-linear
(and, correctly, cap it at 3). However, the actual value is logarithmic
and this ended up generating bad values in the following ranges:

* [20000, 37125] - gave a divisor of 3 not 2
* [40000, 49500] - gave a divisor of 2 not 1
* [74251, 79999] - gave a divisor of 0 not 1
    @jrtc27
    jrtc27 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d7c2cf6 View commit details
    Browse the repository at this point in the history

  4. komeda: Drop temporary resolution hack 

    This was presumably an attempt to work around not having properly
implemented mode_valid in the tda19988 driver.
    @jrtc27
    jrtc27 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    068b1e9 View commit details
    Browse the repository at this point in the history