Add a suffix when printing out-of-bounds capabilities #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it a lot easier to determine whether a capability is out-of-bounds, espeicially if the address look quite similar: ``` (gdb) p e $1 = (FcPatternElt *) 0x42a58200 [rwRW,0x42a558c0-0x42a558f0] (out-of-bounds) ```
bsdjhb
reviewed
Jul 23, 2021
Collaborator
bsdjhb
left a comment
bsdjhb
left a comment
There was a problem hiding this comment.
Hmm, so the way the other attributes work is that they are all grouped together in a comma-separated list in a single set of ()'s. To be consistent, we should also add this to printf/strfcap and the wiki doc. For gdb we'd need to fix the 3 places (maybe I can refactor some of that to use a hook for the permissions printing but use a single copy of code that works with a 'cap').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a lot easier to determine whether a capability is
out-of-bounds, espeicially if the address looks quite similar: