CHERI-RISC-V: PTE_CW/CD bugfix #201
Open
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to assert PAGE_SC_TRAP if either PTE_CW or PTE_CD are clear, as otherise we can end up caching a TLB entry without SC_TRAP for a PTE that's merely got PTE_CW without PTE_CD turned on. This is similar to the existing logic around PTE_D, though this commit adds some commentary clarifying the similarity. I assume the PTE_W/PTE_D test is phrased the way it is for optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to assert PAGE_SC_TRAP if either PTE_CW or PTE_CD are clear, as
otherise we can end up caching a TLB entry without SC_TRAP for a PTE
that's merely got PTE_CW without PTE_CD turned on.
This is similar to the existing logic around PTE_D, though this commit adds some
commentary clarifying the similarity. I assume the PTE_W/PTE_D test is phrased
the way it is for optimization.