Morello instruction tracing nops #257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous merge moved the tcg cflags logic to the tcg_cpu_init_cflags function. This is only called when a vcpu is started to precompute cflags. In order to ensure that TB cflags are compared correctly, curr_cflags must set CF_LOG_INSTR dynamically.
Use the hlt instruction with a custom set of immediates to issue tracing commands. This mirrors the behaviour of the ARM FVP Tarmac trace plugin, which uses the hlt instruction with configurable immediate values to start and stop tracing. Introduce the following hlt immediates: - 0xff00: start instruction tracing - 0xff01: stop instruction tracing - 0xff02: start user-mode instruction tracing
qwattash
force-pushed
the
morello-instr-tracing-nops
branch
from
4dae948 to
6f6f935
Compare
arichardson
approved these changes
Jul 29, 2024
Member
arichardson
left a comment
arichardson
left a comment
There was a problem hiding this comment.
Not checked whether these conflict with anything but change LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.