Skip to content

Update build preview action step to resolve bug #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented May 6, 2025

This PR addresses greenelab#321 within the SET website. We add this update to address the issue outside of #41, where the issue currently is exhibited through the build preview.

Thanks goes to @vincerubinetti, who found the root cause here!

Co-Authored-By: Vincent Rubinetti <[email protected]>
Copy link

github-actions bot commented May 6, 2025

PR Preview Action v1.4.7
🚀 Deployed preview to https://CU-DBMI.github.io/set-website/preview/pr-45/
on branch gh-pages at 2025-05-06 19:18 UTC

@vincerubinetti
Copy link

vincerubinetti commented May 6, 2025

Note that the preview on this PR won't work for the same reason as stated in this comment, because the workflow run here is still using the gh-find-current-pr action. It should work after this PR is merged, and the next PR that is opened.

Co-Authored-By: Vincent Rubinetti <[email protected]>
@d33bs d33bs requested a review from vincerubinetti May 6, 2025 19:18
@d33bs
Copy link
Member Author

d33bs commented May 6, 2025

Thanks @vincerubinetti ! Made some changes - re-requesting your review.

@d33bs
Copy link
Member Author

d33bs commented May 6, 2025

Thanks again @vincerubinetti !

@d33bs d33bs marked this pull request as ready for review May 6, 2025 19:28
@d33bs d33bs merged commit 4503c87 into CU-DBMI:main May 6, 2025
2 checks passed
@d33bs d33bs deleted the fix-for-lab-website-template#321 branch May 6, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants