-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mass-consistent advection. #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And removed superfluous `update self` directive.
And added some example input files for droplet- and bubble-laden Poiseuille flow.
…check`/`iout?d`/`isave` to 0.
gianlupo
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and refactors the consistent advection implementation, which had issues in the calculation of the momentum and heat fluxes that led to stability problems. Other, unrelated minor updates have also been brought to this PR.
While unifying the conservative and non-conservative forms of the momentum equation, we have found some room for optimization and simplification of the implementation. Further steps could be taken that would lead to further simplification, but to keep things more efficient and avoid GPU register pressure, this is deemed to be enough for now.
Summary of changes:
dtmin
->dtmax
in the input file;icheck
/iout?d
/isave
to 0;CONSERVATIVE_MOMENTUM
toCONSISTENT_ADVECTION
;