Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoose v5.6.0 breaks plugin and tests #32

Open
joelrorseth opened this issue Sep 7, 2019 · 1 comment
Open

Mongoose v5.6.0 breaks plugin and tests #32

joelrorseth opened this issue Sep 7, 2019 · 1 comment

Comments

@joelrorseth
Copy link

After updating to the latest mongoose v5.6.13, I noticed that a bunch of my tests were failing. Turns out they were all due to this plugin no longer functioning properly. It appears that the plugin is no longer working when inserted at the global or schema level.

After cloning the repo and running the tests, I discovered that the following are failing for mongoose ^5.6.0:

  1. Should fail validation with custom message on bad ID
  2. Should fail validation on bad ID with IdValidator instance
  3. Should fail validation if bad ID set after previously good ID value
  4. Should fail ID validation in an array of ID references
@zproxyz
Copy link

zproxyz commented Nov 1, 2019

@joelrorseth This PR #33 solves this issue. Waiting @martin-css for making and publishing new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants