New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(id-validator): showing custom error message #33

Merged

martin-css merged 1 commit into CampbellSoftwareSolutions:master from zproxyz:fix/custom-error-message

Oct 31, 2019

zproxyz commented Oct 30, 2019 •

edited

Loading

From Mongoose docs

There are two ways for an promise-based async validator to fail:

If the promise rejects, Mongoose assumes the validator failed with the given error.

If the promise resolves to false, Mongoose assumes the validator failed and creates an error with the given message.

In our case with boolean value, we must use resolve instead reject

This PR resolves issue #32


          fix(id-validator): showing custom error message

32bb962

martin-css merged commit 4c7a722 into CampbellSoftwareSolutions:master

Member

martin-css commented Oct 31, 2019

Thanks for the contribution 👍

zproxyz mentioned this pull request

Mongoose v5.6.0 breaks plugin and tests #32

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet