This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Fix issue with metricsstore metrics being reported under the same namespace as spanstore metrics #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spanstore metrics
tin1337
force-pushed
the
zjan-fix-metric-query-ns
branch
from
c4a390a
to
7120d84
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with metricsstore metrics being reported under the same namespace as spanstore metrics
We have additional tags on the
spansstoremetrics which is causing issues when we deploy with a production setup due to conflicts with metrics frommetricsstore. This was not caught in testing because of a difference in behavior between production setups and all-in-one setups.We opted to move the
metricsstoremetrics to another namespace since we do not need to add the additional tags on those metrics.Related Issue
metricsstoremetric namespace between all-in-one and production query setup jaegertracing/jaeger#4280