Complete Electron platform test assertions in channel_self tests #1386
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
The Electron platform compatibility test in
channel_self.test.tswas incomplete—it verified response success and array structure but didn't assert which channels should be returned, unlike the iOS and Android tests.Added specific channel assertions following the existing test pattern:
production,beta,development,no_access)This is correct because the migration adds
electroncolumn withDEFAULT true, making all seed channels Electron-compatible by default.Test plan
The test validates GET
/channel_selfwithplatform=electron,is_emulator=false,is_prod=truereturns all compatible channels with proper filtering based on:electron=true)allow_device=true)allow_prod=true)public=trueORallow_device_self_set=true)Screenshots
N/A - Backend test changes only
Checklist
bun run lint:backend && bun run lint.accordingly.
my tests
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.