Skip to content

Add C++ iostream logging to VS Code terminal window #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SamuelAsherRivello
Copy link
Contributor

I'm new to C++.

I tested this only on Windows 11* and VS Code*. It works great.

*Latest public versions as of this commit.

Relates to my issue:

#22

Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine on our end @SamuelAsherRivello, thanks for adding. Just if you could remove your changes to main.cpp that would be best. Also feel free to add your name to the readme as a contributor in the README.md.

* Revert main.cpp code to match the main branch
* Update README.md to add contributor
@SamuelAsherRivello
Copy link
Contributor Author

@jonjondev Thanks. Your feedback is complete and committed. Please review and merge.

@jonjondev
Copy link
Member

@SamuelAsherRivello sorry do you mind rebasing on top of latest? Just want to get a passing CI run before merging.

@SamuelAsherRivello
Copy link
Contributor Author

I think that's beyond my git knowledge level. Ideas?

@jonjondev
Copy link
Member

If I understand how you're probably set up on your end, it would probably be something like:

git switch origin/main
git remote add base git@github.com:CapsCollective/raylib-cpp-starter.git
git fetch base
git rebase base/main

@SamuelAsherRivello
Copy link
Contributor Author

I attempted that with the attached failed results.
2024-10-26_11-54-07

Rather than continue to debug it, I created a fresh branch off main and submitted a new PR addressing your complete feedback. Thanks.

#26

@jonjondev
Copy link
Member

Huh, it reads like SSH isn't setup correctly? Either way, that works! Closing this PR in favour of #26.

@jonjondev jonjondev closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants