Fix: Add name protection to freezed union and improve keywords list #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please fix tests |
Author
|
Hi. @Carapacik as I understood the problem was in unformatted file, I fixed it. |
|
I believe I faced the same issue and found that in a case where enum has a list of name associated with it, no escape was done. #401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When freezed union is created from enum that has name matching a keyword(in my case "default"), factory name is not protected as enum value. Keyword list also doesn't have dart types, that also can lead to errors with code gen(in my case I have a model with field called "int").