Merged
Conversation
deuszx
previously requested changes
Aug 23, 2024
Collaborator
deuszx
left a comment
deuszx
left a comment
There was a problem hiding this comment.
Generally looks good but I think you've overcomplicated this a bit w/ the secrets.json and wallet.json setup.
Happy to be convinced otherwise.
krzysztofziobro
approved these changes
Aug 26, 2024
deuszx
approved these changes
Aug 30, 2024
Collaborator
deuszx
left a comment
deuszx
left a comment
There was a problem hiding this comment.
LGTM although I can't run it myself at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple script for deploying Stablepool contract with example setup files.