Skip to content

Fix all imports #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DeborahOlaboye
Copy link

This PR fixes all import statements across the project:

  • Sorted imports according to project style
  • Converted relative imports to absolute where necessary
  • Updated requirements.txt to include all necessary dependencies

Closes #638.

@Valera56pub
Copy link
Contributor

you have to check all files and fix all imports

@djeck1432 djeck1432 self-requested a review July 24, 2025 11:23
@DeborahOlaboye
Copy link
Author

Thank you for the feedback!
I’ve fixed all import issues and updated the requirements.txt file.
Please pull the latest changes and run:

pip install -r requirements.txt

This will ensure your local environment matches the updated dependencies.

@Valera56pub
Copy link
Contributor

from dashboard_app.app.models.watcher import NotificationData #correct import
from ..crud import TelegramCrud  #incorrect import

This is what I want. You have to check all files and do the same (explore the Dockerfiles to understand):

from dashboard_app.app.models.watcher import NotificationData #correct import
from dashboard_app.app.telegram_app.telegram.crud import TelegramCrud  #correct import

@DeborahOlaboye
Copy link
Author

DeborahOlaboye commented Jul 24, 2025

Thank you @Valera56pub for the clarification.

I have updated all files to follow the structure you indicated.

Thank you.

Copy link
Contributor

@Valera56pub Valera56pub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollback requirements.txt

You need to run:
docker-compose -f devops/dev/docker-compose.dashboard-app.yaml up --build
AND
docker-compose -f devops/dev/docker-compose.data-handler.yaml up --build

To check whether it builds and runs without errors

@DeborahOlaboye DeborahOlaboye closed this by deleting the head repository Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all imports
2 participants