Skip to content

Remove duplicates of the ProtocolIDs #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove duplicates of the ProtocolIDs #642

wants to merge 3 commits into from
+108 −138

Conversation

DeborahOlaboye
Copy link

This PR removes duplicate ProtocolIDs definitions and declares it in the shared folder.

Changes include:

  • Removed duplicate ProtocolIDs definitions.
  • Updated ProtocolIDs to the correct structure.
  • Moved ProtocolIDs to the shared folder.
  • Updated all imports across the project to reference the new location.

Closes #636

Valera56pub
Valera56pub suggested changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@Valera56pub Valera56pub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have created a branch not from the master but from the previous task's branch. You need to create a branch from the master.

Here is the search for ProtocolIDs - I do not see that you have made changes in all these files.

Image

@DeborahOlaboye DeborahOlaboye closed this by deleting the head repository Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valera56pub Valera56pub Valera56pub requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicates of the ProtocolIDs
2 participants
@DeborahOlaboye @Valera56pub