[pull] master from MusicPlayerDaemon:master #27
Merged
+72
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Starting with alsa-lib 1.2.14, there is a "#warning" in alsa/error.h:
```
In file included from ../../src/lib/alsa/Error.cxx:7:
/usr/include/alsa/error.h:30:2: error: #warning "use #include <alsa/asoundlib.h>, <alsa/error.h> should not be used directly" [-Werror=cpp]
30 | #warning "use #include <alsa/asoundlib.h>, <alsa/error.h> should not be used directly"
| ^~~~~~~
```
This means we can't use minimal includes anymore and must endure
ALSA's header bloat. Pity.
InputStream::ReadFull will assert on an empty buffer, which can happen on an empty RIFF/AIFF chunk. Closes #2299
We switched from plain C localtime() to fmt::localtime() in commit 093122a but fmt 11.2.0 has deprecated fmt::localtime() in favor of std::localtime()... sigh.
This appears to fix the libsndfile subproject build which queries the global "default_library" option.
Pass the unique_lock as rvalue reference and unlock it instead of using ScopeUnlock, which unlocks and re-locks the mutex; then the caller unlocks it again. This eliminates a tiny bit of overhead.
When playback is paused at the end of a track due to "single" mode, the source is first flushed and the output is drained (both does not happen when pausing manually). This sets source_state=FLUSHED which means playback cannot be resumed until the AudioOutputSource is reopened. This however does not happen because AudioOutputControl::Open() thinks it is not necessary; this method however did not consider the AudioOutputSource flush state. The solution is to add yet another flag called "should_reopen" which is set whenever the source is flushed. Closes #2279
… files This call was missing after OpenLocalInputStream(), leading to all "getfingerprint" calls with io_uring to become stuck because nobody would notify the condition variable. Closes #2286
release v0.24.4
Reviewer's GuideThis PR introduces a reopen-after-flush mechanism and refactors AudioOutputControl’s Open API to use movable locks, improves atomic file downloads in the build script, hardens log date formatting, updates destructor signatures and build defaults, and applies several small bugfixes and cleanups. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Hard-Coded Secrets (5)
More info on how to fix Hard-Coded Secrets in General. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Add a reopening mechanism for audio output after flush, tighten lock and error handling, refine build scripts for static linking, and improve file download safety.
Bug Fixes:
Enhancements:
Build: