[pull] master from MusicPlayerDaemon:master

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Refactor playlist playback logic by extracting a unified PlayOrder implementation, introducing PlayAny for resume behavior, simplifying PlayPosition and PlayId APIs, and updating command handlers and Partition to leverage the new methods.

New Features:

• Introduce a PlayAny method in Playlist to resume or play the current/first song.

Enhancements:

• Extract and centralize order-based playback logic into a new PlayOrder method.
• Simplify PlayPosition and PlayId by validating inputs and delegating to PlayOrder.
• Change PlayPosition and PlayId signatures to use unsigned types for consistency.
• Update PlayerCommands to invoke PlayAny when no arguments are given for play/playid.
• Add a PlayAny wrapper in Partition to expose the new resume functionality.

[sourcery-ai]

Reviewer's Guide

This PR restructures playlist playback control by extracting core PlayOrder logic into PlaylistControl, adding a new PlayAny method for default/resume playback, standardizing PlayPosition/PlayId parameters to unsigned, and updating command handlers to use the new API.

Class Diagram: Changes to Playlist and Partition

classDiagram
  class Playlist {
    +PlayAny(PlayerControl pc) void
    +PlayPosition(PlayerControl pc, unsigned position) void
    +PlayId(PlayerControl pc, unsigned id) void
  }
  class Partition {
    -playlist: Playlist
    -pc: PlayerControl
    +PlayAny() void
    +PlayPosition(int position) void
    +PlayId(int id) void
  }
  class QueueListener {
    <<interface>>
  }
  class PlayerListener {
    <<interface>>
  }
  class MixerListener {
    <<interface>>
  }

  Partition o-- "1" Playlist : uses
  Partition --|> QueueListener
  Partition --|> PlayerListener
  Partition --|> MixerListener

Loading

File-Level Changes

Change	Details	Files
Refactored internal playback workflow	Relocated PlayOrder implementation from Playlist.cxx to PlaylistControl.cxx Unified PlayPosition to delegate to PlayOrder Removed duplicate PlayOrder block from Playlist.cxx	src/queue/PlaylistControl.cxx src/queue/Playlist.cxx
Added PlayAny for default or resume playback	Introduced PlayAny method to select current or first song and unpause if already playing Moved pause-clearing and error-reset logic into PlayAny Called PlayOrder from PlayAny	src/queue/PlaylistControl.cxx src/queue/Playlist.hxx
Standardized playback method signatures	Changed PlayPosition and PlayId to accept unsigned values instead of int Updated Playlist.hxx declarations and Partition.hxx wrappers accordingly	src/queue/Playlist.hxx src/Partition.hxx
Updated client commands to new playback API	handle_play now invokes PlayAny when no arg or PlayPosition with unsigned arg handle_playid similarly routes to PlayAny or PlayId	src/command/PlayerCommands.cxx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.