Skip to content

[pull] master from MusicPlayerDaemon:master #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented May 22, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Refactor PlayerControl locking methods to improve efficiency and enforce move semantics for song objects.

Enhancements:

  • Mark PauseLocked, EnqueueSongLocked, and SeekLocked as inline in Control.cxx.
  • Change EnqueueSongLocked and SeekLocked signatures to accept std::unique_ptr&& instead of by value.

@pull pull bot added the ⤵️ pull label May 22, 2025
@pull pull bot merged commit 5a80d14 into CartoonFan:master May 22, 2025
1 check was pending
Copy link

sourcery-ai bot commented May 22, 2025

Reviewer's Guide

This PR optimizes internal player control routines by marking key methods inline and refines ownership semantics by changing DetachedSong parameters to rvalue references, updating both implementation and headers accordingly.

File-Level Changes

Change Details Files
Added inline specifier to internal control methods
  • Prefixed PauseLocked with inline in Control.cxx
  • Prefixed EnqueueSongLocked with inline in Control.cxx
  • Prefixed SeekLocked with inline in Control.cxx
src/player/Control.cxx
Refactored song parameter to rvalue reference
  • Changed EnqueueSongLocked to accept std::unique_ptr&& in implementation
  • Updated EnqueueSongLocked declaration to use && in Control.hxx
  • Changed SeekLocked signature to accept std::unique_ptr&& in implementation
  • Updated SeekLocked declaration accordingly in Control.hxx
src/player/Control.cxx
src/player/Control.hxx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant