Minor fixes #17
Merged
Minor fixes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pic module to correctly handle 1D cases.
… in load creation.
…d update solver methods to save parameters to CSV files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple files, focusing on enhancing functionality, improving documentation, and refining code for better usability and clarity. The most notable updates include the addition of parameter export methods, adjustments to material models for dimensional flexibility, and improvements to loading functions.
Enhancements to simulation parameter management:
src/phasefieldx/Element/Elasticity/Input.py: Added a methodsave_parameters_to_csvto export simulation parameters to a CSV file for easier integration with data analysis tools like pandas. Updated the class docstring to reflect this addition. [1] [2]src/phasefieldx/Element/Phase_Field/Input.py: Similar updates as above, with the addition ofsave_parameters_to_csvand updated documentation. [1] [2]src/phasefieldx/Element/Phase_Field_Fracture/Input.py: Introduced thesave_parameters_to_csvmethod and updated the class docstring to include the new functionality. [1] [2]Adjustments to material models:
src/phasefieldx/Materials/elastic_isotropic.py: Modifiedepsilonandpsifunctions to handle 1D cases by adapting strain and energy density calculations based on the mesh dimension. [1] [2]Improvements to loading functions:
src/phasefieldx/Loading/loading_functions.py: Refactoredloading_Tx,loading_Txy, andloading_Txyzfunctions to simplify their signatures and improve usability. These functions now support constant scalar or vector loads directly, without requiring additional function spaces or facets.Updates to documentation and metadata:
README.rst: Added a DeepWiki badge and link to provide users with an AI-powered knowledge base for exploring the project. [1] [2]pyproject.toml: Updated author email to "[email protected]" for better contact management.Miscellaneous changes:
CODE_OF_CONDUCT.mdandCONTRIBUTING.rst: Removed specific email addresses to streamline communication channels and encourage platform-based discussions. [1] [2]examples/Elasticity/plot_1101.py: Simplified theloading_Txyfunction call to match the updated function signature.