optimistic locking #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded several dependencies including @babel packages, formidable, brace-expansion, and picocolors. Added @paralleldrive/cuid2 and @noble/hashes as new dependencies, and removed hexoid and to-fast-properties. These updates improve compatibility and address potential security or maintenance issues.
|
Ready for Review. This Tiny change should consider incoming requests on the /overwrite path and passthrough the On a 409 error, the This change does not require any change to Services, RERUM, or Interfaces, but will never 409 until the upstream chain is in place. |
thehabes
approved these changes
Jun 30, 2025
| } | ||
|
|
||
| // Check for __rerum.isOverwritten in body and use as If-Overwritten-Version header | ||
| const isOverwrittenValue = req.body?.__rerum?.isOverwritten |
There was a problem hiding this comment.
I think just let the header be the trigger and remove this check. It isn't doing much harm, but it means if I forget to scrub __rerum from the request body then I am triggering an optimistic locking overwrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to CenterForDigitalHumanities/rerum_server_nodejs#198
header "If-Overwritten-Version" should match the
__rerum.isOverWrittenproperty.