Gallica: add Resistance journals #1793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukavdplas
approved these changes
Jun 23, 2025
| from corpora.gallica.gallica import Gallica | ||
|
|
||
|
|
||
| class Resistance(Gallica): |
There was a problem hiding this comment.
Re. both the corpus name and index name, perhaps resistance-journals or journaux-resistance would be clearer than resistance?
Co-authored-by: Luka van der Plas <[email protected]>
Co-authored-by: Luka van der Plas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corpus consists of a number of different journals, all added by their own id. The branch also adds and changes licenses and descriptions of the other Gallica corpora: while adding the missing Caricature description, I noticed that the previously chosen picture was factually from a later periodical by that same name, not the 1830-1843 periodical.