interrupt index jobs #1799
Merged
interrupt index jobs #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-krauchenco-mottu
previously approved these changes
May 15, 2025
There was a problem hiding this comment.
Nice managment interface for stopping.
I have some doubts about the raise_if_aborted mechanism. This goed against my (maybe unjustly so) feeling that a raise should occur whenever something fails, and you should not need to ask explicitly "we still okay?"
Ofcourse open to explanation as to why this should work like this.
Co-Authored-By: Jelte van Boheemen <[email protected]>
Co-Authored-By: Jelte van Boheemen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to stop index jobs, either via the admin or the command line.
close #1697