Skip to content

Export tags and document link in .csv #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

BeritJanssen
Copy link
Contributor

Close #1195, also updated the download manual, which still described the situation prior to the download module.

@lukavdplas
Copy link
Contributor

Without going into the code implementation, I have a few general comments:

  • Did you see Support extra csv columns for search results download #1195 (comment) ? If so, is there a reason you went in a different direction?
  • The download component includes a "additional columns" section to include non-field columns. (Currently hidden because query-in-context downloads don't work in the backend, and that was the only option. So I can imagine you may have missed this.) I think this would be the appropriate place to include tags and the url, rather than in the field dropdown. (This field dropdown is like, 5 cm below another field dropdown that does not include those options.)
  • The manual update overlaps with more manual #1811 which also updates the download manual to the current situation. No changes requested here, just pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support extra csv columns for search results download
2 participants