Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming image from work space #439

Merged
merged 26 commits into from
Jun 29, 2021
Merged

Renaming image from work space #439

merged 26 commits into from
Jun 29, 2021

Conversation

devenyantis
Copy link
Contributor

@devenyantis devenyantis commented Jun 24, 2021

Description

Users are able to rename image.

Tested for data with and without child directory.

Frontend PR: #438

  • Press button besides image to rename
  • Also F2 for rename shortcut key

Will update documentation, changelog and gitbook api docs if accepted.

Type of change

Please delete options that are not relevant.

  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Example: REST API changes)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged
  • CHANGELOG.md has been updated
  • Update Gitbook REST API Page

@devenyantis devenyantis requested a review from codenamewei June 24, 2021 09:30
@devenyantis devenyantis self-assigned this Jun 24, 2021
@devenyantis devenyantis added the enhancement New feature or request label Jun 24, 2021
@devenyantis
Copy link
Contributor Author

@codenamewei

Tested with the frontend PR

How I test

  1. Create new branch (dummy branch for testing only) based on this branch
  2. Merge the frontend auto PR Copying and pasting dist folder's contents from Classifai_FrontEnd to classifai's webroot #438
  3. Perform functions test.

@codenamewei
Copy link
Contributor

@devenyantis thanks for the guided pointers to test on this PR

im seeing the full path in the edit image

Screenshot 2021-06-28 at 8 42 23 AM

is that intentional?
path: /Users/chiawei/Desktop/classifai_dataset/Agriculture-sample-12345/Agriculture-sample-123/agriculture-sample-123456/animal11

changing other than image name will resulted in following

Screenshot 2021-06-28 at 8 44 02 AM

Copying and pasting dist folder's contents from Classifai_FrontEnd to classifai's webroot
@codenamewei
Copy link
Contributor

@devenyantis i've merge working frontend (faris_auto_pr) to this branch, do a fresh pull if needed. thanks

@devenyantis
Copy link
Contributor Author

@devenyantis thanks for the guided pointers to test on this PR

im seeing the full path in the edit image

Screenshot 2021-06-28 at 8 42 23 AM

is that intentional?
path: /Users/chiawei/Desktop/classifai_dataset/Agriculture-sample-12345/Agriculture-sample-123/agriculture-sample-123456/animal11

changing other than image name will resulted in following

Screenshot 2021-06-28 at 8 44 02 AM

@codenamewei

Does the image name on the data list also show the full path?

@codenamewei
Copy link
Contributor

not able to do pr merge due to how there's conflicts , probably due how the auto pr is based on v2_alpha
webroot is directly updated in a commit to this branch

do a pull thanks, @devenyantis

devenyantis and others added 2 commits June 29, 2021 17:36
Copying and pasting dist folder's contents from Classifai_FrontEnd to classifai's webroot
@devenyantis devenyantis requested a review from codenamewei June 29, 2021 09:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codenamewei codenamewei merged commit a5f3ccf into v2_alpha Jun 29, 2021
@codenamewei codenamewei deleted the deven_addRenameImage branch June 29, 2021 11:06
@codenamewei
Copy link
Contributor

codenamewei commented Jun 29, 2021

@devenyantis
not too sure do you want to put items below in this PR, only realised after i merged.
do work on updating documentation, changelog and gitbook api docs accordingly thanks!

@devenyantis
Copy link
Contributor Author

@devenyantis
not too sure do you want to put items below in this PR, only realised after i merged.
do work on updating documentation, changelog and gitbook api docs accordingly thanks!

Sure. Will update the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants