New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove `GLM_FORCE_SIZE_T_LENGTH` #1056

Open

lilleyse wants to merge 2 commits into main from remove-GLM_FORCE_SIZE_T_LENGTH

+14 −8

Contributor

lilleyse commented Jan 8, 2025

This flag goes against our style guide recommendation to default to signed types: https://github.com/CesiumGS/cesium-native/blob/main/doc/topics/style-guide.md#-integers

Also, on a more practical note, this made it easier for me to integrate a library that uses glm that doesn't compile when this flag is set.

lilleyse added 2 commits

January 8, 2025 16:08


          Remove GLM_FORCE_SIZE_T_LENGTH

e62cfd7


          Fix clang errors

d278951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet