Merged
Conversation
Some tests are still failing, so WIP
Even though tests in Cesium3DTilesSelection/test/TestTilesetHeightQueries.cpp pass with the dispatch after loadTiles(), move it before in order to be consistant with the order we've used elsewhere.
This was referenced Mar 5, 2026
Merged
Contributor
Author
|
The tests themselves did have some explicit calls to dispatchMainThreadTasks() already, and they were placed after loadTiles(), so when I was first getting the tests working I put the new calls after too. I'll investigate and see if they can before or if they are still needed. |
For new uses of dispatchMainThreadTasks(), always put it before loadTiles(). This behavior is essentially the same as when dispatchMainThreadTasks() was included in loadTiles().
j9liu
approved these changes
Mar 16, 2026
timoore
added a commit
to CesiumGS/cesium-unreal
that referenced
this pull request
Mar 17, 2026
PR CesiumGS/cesium-native#1315 was merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove calls to
asyncSystem::dispatchMainThreadTasksfrom tileset selection functionsupdateViewGroup,updateViewGroupOffline, andloadTiles. This is a breaking change; client applications need to calldispatchMainThreadTasksto make progress.Addresses #605