Fix the macOS / iOS build #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the same exclude list as Linux currently.
csciguy8
suggested changes
May 22, 2024
There was a problem hiding this comment.
Thanks for the prompt fixes @kring !
Verified all the macOS / iOS builds are good and we aren't running out of disk space. Although we seem to be getting close to problems for the 5.3 builds, up to 94% of capacity.
Just a few comments, but the only thing that may need to be changed could be moving the KTX configuration to cesium-native.
Let me know what you think.
|
Love the branch name, btw |
|
Main is broken. This PR fixes it. Let's get it merged. |
csciguy8
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426
By switching to the macos-13 runner, which has much more disk space than the macos-12 one. Also excluded the
.dSYMfiles (Editor debug symbols) from the UE distribution.Fixes #1427
By setting the ktx library to not be a "framework" on iOS.